kaijchen commented on code in PR #32010:
URL: https://github.com/apache/doris/pull/32010#discussion_r1754191510


##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -3243,158 +3243,183 @@ public void unsetFields() {
 
         // update profile.
         // return true if profile is updated. Otherwise, return false.
-        public synchronized boolean updateProfile(TReportExecStatusParams 
params) {
+        // Has to use synchronized to ensure there are not concurrent update 
threads. Or the done
+        // state maybe update wrong and will lose data. see 
https://github.com/apache/doris/pull/29802/files.
+        public synchronized boolean 
updatePipelineStatus(TReportExecStatusParams params) {
+            // The fragment or instance is not finished, not need update
+            if (!params.done) {
+                return false;

Review Comment:
   This caused a problem where progress reports for `show load` command is 
ignored until the entire fragment instance is finished.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to