This is an automated email from the ASF dual-hosted git repository.
w41ter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new d77d74ac8a3 [fix](restore) Remove the sqlMode from the view signature
(#40615)
d77d74ac8a3 is described below
commit d77d74ac8a33d1799faca95b593f20986c8fc206
Author: walter <w41te...@gmail.com>
AuthorDate: Wed Sep 11 19:34:38 2024 +0800
[fix](restore) Remove the sqlMode from the view signature (#40615)
To keep compatible with the old version, without sqlMode, if the
signature of views are the same, we should have the same sqlMode. (since
the sqlMode doesn't affect the parsing of inlineViewDef, otherwise the
parsing will fail)
---
fe/fe-core/src/main/java/org/apache/doris/catalog/View.java | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/View.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/View.java
index 62402c7d474..707464aeaf7 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/View.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/View.java
@@ -223,7 +223,14 @@ public class View extends Table implements
GsonPostProcessable {
sb.append(type);
sb.append(Util.getSchemaSignatureString(fullSchema));
sb.append(inlineViewDef);
- sb.append(sqlMode);
+
+ // ATTN: sqlMode is missing when persist view, so we should not append
it here.
+ //
+ // To keep compatible with the old version, without sqlMode, if the
signature of views
+ // are the same, we think the should has the same sqlMode. (since the
sqlMode doesn't
+ // effect the parsing of inlineViewDef, otherwise the parsing will
fail),
+ //
+ // sb.append(sqlMode);
String md5 = DigestUtils.md5Hex(sb.toString());
if (LOG.isDebugEnabled()) {
LOG.debug("get signature of view {}: {}. signature string: {}",
name, md5, sb.toString());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
