yiguolei commented on code in PR #8855:
URL: https://github.com/apache/incubator-doris/pull/8855#discussion_r849386065
##########
be/src/olap/memtable_flush_executor.cpp:
##########
@@ -67,7 +71,10 @@ void FlushToken::_flush_memtable(std::shared_ptr<MemTable>
memtable, int64_t sub
MonotonicStopWatch timer;
timer.start();
- _flush_status.store(memtable->flush());
+ Status s = memtable->flush();
+ LOG(WARNING) << "Flush memtable failed with res = " << s;
+ // If s is not ok, ignore the code, just use other code is ok
+ _flush_status.store(s.ok() ? OLAP_SUCCESS : OLAP_ERR_OTHER_ERROR);
Review Comment:
Error code in S is int16_t, it may not be converted to ErrorCode. And I find
we did not justify the errorcode in other code. So that I print the error stack
in LOG(WARNING) and using OTHER_ERROR here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
