wangbo commented on code in PR #8855:
URL: https://github.com/apache/incubator-doris/pull/8855#discussion_r846936640
##########
be/src/agent/agent_server.cpp:
##########
@@ -208,17 +208,14 @@ void AgentServer::submit_tasks(TAgentResult& agent_result,
void AgentServer::make_snapshot(TAgentResult& t_agent_result,
const TSnapshotRequest& snapshot_request) {
- Status ret_st;
string snapshot_path;
bool allow_incremental_clone = false;
- OLAPStatus err_code =
+ Status err_code =
SnapshotManager::instance()->make_snapshot(snapshot_request,
&snapshot_path, &allow_incremental_clone);
- if (err_code != OLAP_SUCCESS) {
+ if (!err_code) {
Review Comment:
I think maybe ret_code is better.
```err_code ``` is not a good name.It seems like ```!error_code``` means no
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
