zhangstar333 commented on code in PR #40317:
URL: https://github.com/apache/doris/pull/40317#discussion_r1741665899
##########
be/test/vec/core/get_common_type_test.cpp:
##########
@@ -143,10 +146,8 @@ INSTANTIATE_TEST_SUITE_P(data_type, LeastSuperTypeTest,
{"Float32 Float64", "Float64"},
{"Float32 UInt16 Int32", "Float64"},
{"Float32 Int16 UInt32", "Float64"},
- {"Date Date", "Date"},
- {"DateTime DateTime", "DateTime"},
{"String String String", "String"},
- {"Int8 String", nullptr},
Review Comment:
could remove those test case of return nullptr
now return jsonb seems the default result as get_least_supertype_jsonb.
so those test case is useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
