zhangstar333 commented on code in PR #40317:
URL: https://github.com/apache/doris/pull/40317#discussion_r1741617169
##########
be/test/vec/core/get_common_type_test.cpp:
##########
@@ -143,10 +146,8 @@ INSTANTIATE_TEST_SUITE_P(data_type, LeastSuperTypeTest,
{"Float32 Float64", "Float64"},
{"Float32 UInt16 Int32", "Float64"},
{"Float32 Int16 UInt32", "Float64"},
- {"Date Date", "Date"},
Review Comment:
it's should be fixed at be/src/vec/data_types/get_least_supertype.cpp
line:288
add datev2 and datetimev2
` if (which.is_date_v2()) {
*type = std::make_shared<DataTypeDateV2>();
return;
}
if (which.is_date_time_v2()) {
*type = std::make_shared<DataTypeDateTimeV2>();
return;
}`
##########
be/test/vec/core/get_common_type_test.cpp:
##########
@@ -143,10 +146,8 @@ INSTANTIATE_TEST_SUITE_P(data_type, LeastSuperTypeTest,
{"Float32 Float64", "Float64"},
{"Float32 UInt16 Int32", "Float64"},
{"Float32 Int16 UInt32", "Float64"},
- {"Date Date", "Date"},
- {"DateTime DateTime", "DateTime"},
{"String String String", "String"},
- {"Int8 String", nullptr},
Review Comment:
I think could remove those, no need change to Jsonb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
