joker-star-l commented on code in PR #39546: URL: https://github.com/apache/doris/pull/39546#discussion_r1734313580
########## fe/fe-core/src/test/java/org/apache/doris/nereids/rules/analysis/GenerateFunction.java: ########## @@ -95,6 +95,7 @@ import java.util.function.Supplier; import java.util.stream.Collectors; +@Deprecated Review Comment: If I understand correctly, this class has not been maintained for several years, but each Function definition class has a line `This class is generated by GenerateFunction`, like [`Histogram`](https://github.com/apache/doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Histogram.java). Maybe this is a kind of misleadingness, especially for new guys. So I add the `@Deprecated`. If this is not correct, I will remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
