morrySnow commented on code in PR #39546:
URL: https://github.com/apache/doris/pull/39546#discussion_r1734212023
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinAggregateFunctions.java:
##########
@@ -112,6 +113,7 @@ public class BuiltinAggregateFunctions implements
FunctionHelper {
agg(GroupBitmapXor.class, "group_bitmap_xor"),
agg(GroupConcat.class, "group_concat"),
agg(Histogram.class, "hist", "histogram"),
+ agg(LinearHistogram.class, "linear_histogram"),
Review Comment:
add in lexicographical order
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/analysis/GenerateFunction.java:
##########
@@ -95,6 +95,7 @@
import java.util.function.Supplier;
import java.util.stream.Collectors;
+@Deprecated
Review Comment:
why add this?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/visitor/AggregateFunctionVisitor.java:
##########
@@ -198,6 +199,10 @@ default R visitHistogram(Histogram histogram, C context) {
return visitAggregateFunction(histogram, context);
}
+ default R visitLinearHistogram(LinearHistogram linearHistogram, C context)
{
+ return visitAggregateFunction(linearHistogram, context);
+ }
+
Review Comment:
add in lexicographical order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
