morningman commented on code in PR #38549:
URL: https://github.com/apache/doris/pull/38549#discussion_r1723550266
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1111,6 +1113,9 @@ public class SessionVariable implements Serializable,
Writable {
"set the number of sort phases 1 or 2. if set other value,
let cbo decide the sort type"})
public int sortPhaseNum = 0;
+ @VariableMgr.VarAttr(name = HIVE_TEXT_COMPRESSION, needForward = true)
+ private String hiveTextCompression = "uncompressed";
Review Comment:
What is this variable for?
##########
be/src/util/slice.h:
##########
@@ -358,6 +358,10 @@ class OwnedSlice : private Allocator<false, false, false,
DefaultMemoryAllocator
return *this;
}
+ // disable copy constructor and copy assignment
Review Comment:
need to change comment.
And why make it public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
