suxiaogang223 commented on code in PR #38549: URL: https://github.com/apache/doris/pull/38549#discussion_r1724562470
########## be/src/util/slice.h: ########## @@ -358,6 +358,10 @@ class OwnedSlice : private Allocator<false, false, false, DefaultMemoryAllocator return *this; } + // disable copy constructor and copy assignment Review Comment: just follow the clang-tidy worrying https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-delete.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org