TangSiyang2001 commented on code in PR #23836:
URL: https://github.com/apache/doris/pull/23836#discussion_r1715260021
##########
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##########
@@ -645,6 +645,13 @@ protected boolean cancelImpl(String errMsg) {
return false;
}
+ try {
+ this.deleteTabletWatermarkTxnId =
+
Env.getCurrentGlobalTransactionMgr().getNextTransactionId();
+ } catch (UserException e) {
+ LOG.warn("get next transaction id failed");
+ }
Review Comment:
This assign method could be better put into AlterJob.java, just add an
unified method like:
```java
protected void assignDeleteTabletWatermarkTxnId() {
try {
this.deleteTabletWatermarkTxnId =
Env.getCurrentGlobalTransactionMgr().getNextTransactionId();
} catch (UserException e) {
LOG.warn("get next transaction id failed");
}
}
```
and we cloud just call assignDeleteTabletWatermarkTxnId() here and also in
SchemaChangeJobV2, even in CloudSchemaChangeJob and CloudRollupJob in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
