DarvenDuan commented on code in PR #23836:
URL: https://github.com/apache/doris/pull/23836#discussion_r1714952016


##########
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##########
@@ -134,6 +134,10 @@ public class RollupJobV2 extends AlterJobV2 implements 
GsonPostProcessable {
     @SerializedName(value = "storageFormat")
     private TStorageFormat storageFormat = TStorageFormat.DEFAULT;
 
+    // used for delete decommission tablet
+    @SerializedName(value = "watermarkTxnId")
+    private long watermarkTxnId = -1;
+

Review Comment:
   done



##########
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##########
@@ -641,6 +645,12 @@ protected boolean cancelImpl(String errMsg) {
             return false;
         }
 
+        try {
+            this.watermarkTxnId =
+                    
Env.getCurrentGlobalTransactionMgr().getNextTransactionId();
+        } catch (Exception e) {
+            LOG.warn("get next transaction id failed");
+        }

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to