JNSimba commented on code in PR #450:
URL:
https://github.com/apache/doris-flink-connector/pull/450#discussion_r1692806135
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/postgres/PostgresDatabaseSync.java:
##########
@@ -84,9 +84,13 @@ public void registerDriver() throws SQLException {
@Override
public Connection getConnection() throws SQLException {
+ Properties jdbcProperties = getJdbcProperties();
+ StringBuilder jdbcUrlSb = new StringBuilder(JDBC_URL);
+ jdbcProperties.forEach(
+ (key, value) ->
jdbcUrlSb.append("&").append(key).append("=").append(value));
Review Comment:
It is better to add a UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
