DongLiang-0 commented on code in PR #450: URL: https://github.com/apache/doris-flink-connector/pull/450#discussion_r1692768497
########## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/db2/Db2DatabaseSync.java: ########## @@ -89,12 +89,26 @@ public void registerDriver() throws SQLException { @Override public Connection getConnection() throws SQLException { + Properties jdbcProperties = getJdbcProperties(); + StringBuilder jdbcParams = new StringBuilder(); + int cnt = 0; Review Comment: Is it more appropriate to use boolean here? ```suggestion boolean firstParam = true; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org