xinyiZzz commented on a change in pull request #8443:
URL: https://github.com/apache/incubator-doris/pull/8443#discussion_r825324950



##########
File path: be/src/runtime/plan_fragment_executor.cpp
##########
@@ -86,28 +86,6 @@ Status PlanFragmentExecutor::prepare(const 
TExecPlanFragmentParams& request,
     _runtime_state.reset(new RuntimeState(params, request.query_options, 
query_globals, _exec_env));
     _runtime_state->set_query_fragments_ctx(fragments_ctx);
 
-    RETURN_IF_ERROR(_runtime_state->init_mem_trackers(_query_id));

Review comment:
       fragment_mem_tracker should be a child of query_mem_tracker.
   And after segmentV1 is abandoned, the only use of fragment_mem_tracker is to 
count the memory consumption of Rowset Reader and Tablet Reader in OlapScanner, 
which has been replaced by _scanner_mem_tracker after MemTracker is refactored.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to