dataroaring opened a new pull request #8443: URL: https://github.com/apache/incubator-doris/pull/8443
Now OlapSanner allocates memory by calling MemPool::allocate method, however, MemPool::allocate does not check limit, so we should call MemPool::try_allocate instead of MemPool::allocate. OlapTableSink use a MemTracker whose parent is instance MemTracker, (instance MemTracker -> query MemTracker -> Process MemTracker), and OlapTableSink sleeps when usage of memory exceeds limit to avoid too much memory consumption, however the limit is ProcessMemTracker's. So we should let query fragment inherits from FragmentMemTracker. This patch can avoids oom crash, and the select * or insert into select fails due to memory over limit. We should add another patch, which control memory consumption of OlapScanner and OlapTableSink by percent of exec_mem_limit. Thus, the query does not fail due to memory over limit. # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
