github-actions[bot] commented on code in PR #36786: URL: https://github.com/apache/doris/pull/36786#discussion_r1665439318
########## cloud/src/meta-service/meta_service_partition.cpp: ########## @@ -614,4 +621,93 @@ void MetaServiceImpl::drop_partition(::google::protobuf::RpcController* controll } } +void check_create_table(std::string instance_id, std::shared_ptr<TxnKv> txn_kv, + const CheckKVRequest* request, CheckKVResponse* response, + MetaServiceCode* code, std::string* msg, Review Comment: warning: pointer parameter 'msg' can be pointer to const [readability-non-const-parameter] ```suggestion MetaServiceCode* code, const std::string* msg, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org