gavinchou commented on code in PR #36786:
URL: https://github.com/apache/doris/pull/36786#discussion_r1652718155
##########
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java:
##########
@@ -582,9 +587,60 @@ private void executeDynamicPartition(Collection<Pair<Long,
Long>> dynamicPartiti
}
if (!skipAddPartition) {
- for (AddPartitionClause addPartitionClause :
addPartitionClauses) {
+ // get partitionIds and indexIds
+ List<Long> indexIds = new
ArrayList<>(olapTable.getCopiedIndexIdToMeta().keySet());
+ List<Long> generatedPartitionIds = new ArrayList<>();
Review Comment:
extract to a separate function
##########
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java:
##########
@@ -594,6 +650,55 @@ private void executeDynamicPartition(Collection<Pair<Long,
Long>> dynamicPartiti
}
}
}
+ List<Long> succeedPartitionIds =
partsInfo.stream().map(partitionPersistInfo
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
