ghkang98 commented on code in PR #36289:
URL: https://github.com/apache/doris/pull/36289#discussion_r1642054711
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergTransaction.java:
##########
@@ -59,140 +66,114 @@ public void
updateIcebergCommitData(List<TIcebergCommitData> commitDataList) {
}
}
- public void beginInsert(String dbName, String tbName) {
- Table icebergTable =
ops.getCatalog().loadTable(TableIdentifier.of(dbName, tbName));
- transaction = icebergTable.newTransaction();
+ public void pendingCommit(SimpleTableInfo tableInfo) {
Review Comment:
This can be unified with hive, but I think pendingCommit, precommit and
commit are more suitable, and hive can also move towards this aspect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
