wuwenchi commented on code in PR #36289:
URL: https://github.com/apache/doris/pull/36289#discussion_r1642049627


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergTransaction.java:
##########
@@ -59,140 +66,114 @@ public void 
updateIcebergCommitData(List<TIcebergCommitData> commitDataList) {
         }
     }
 
-    public void beginInsert(String dbName, String tbName) {
-        Table icebergTable = 
ops.getCatalog().loadTable(TableIdentifier.of(dbName, tbName));
-        transaction = icebergTable.newTransaction();
+    public void pendingCommit(SimpleTableInfo tableInfo) {
+        this.tableInfo = tableInfo;
+        this.transaction = getNativeTable(tableInfo).newTransaction();

Review Comment:
   The table in the cache cannot be used here, because the table here is not 
necessarily the same as the cached table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to