englefly commented on code in PR #35517:
URL: https://github.com/apache/doris/pull/35517#discussion_r1618364638
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsRepository.java:
##########
@@ -409,6 +415,18 @@ public static List<ResultRow> loadColStats(long ctlId,
long dbId, long tableId,
.replace(FETCH_COLUMN_STATISTIC_TEMPLATE));
}
+ public static List<ResultRow> loadPartitionStats(long ctlId, long dbId,
long tableId, long idxId,
Review Comment:
loadPartitionColumnStats()
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java:
##########
@@ -92,6 +100,24 @@ public ColumnStatistic getColumnStatistics(long catalogId,
long dbId, long tblId
return ColumnStatistic.UNKNOWN;
}
+ public PartitionStatistic getPartitionStatistics(long catalogId, long
dbId, long tblId, long idxId,
Review Comment:
it would be better to rename to getPartitionColumnStatistics()
And how about changing params of getColumnStatistics(..., partId, ...) and
make getPartitionStatistics private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
