Jibing-Li commented on code in PR #35517: URL: https://github.com/apache/doris/pull/35517#discussion_r1617363996
########## fe/fe-core/src/main/java/org/apache/doris/statistics/PartitionStatistic.java: ########## @@ -0,0 +1,165 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.statistics; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.catalog.Column; +import org.apache.doris.common.AnalysisException; +import org.apache.doris.common.io.Hll; +import org.apache.doris.statistics.util.Hll128; +import org.apache.doris.statistics.util.StatisticsUtil; + +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.io.ByteArrayInputStream; +import java.io.DataInputStream; +import java.util.Base64; +import java.util.List; + +public class PartitionStatistic { + + private static final Logger LOG = LogManager.getLogger(PartitionStatistic.class); + + public static PartitionStatistic UNKNOWN = new PartitionStatisticBuilder().setAvgSizeByte(1).setNdv(new Hll128()) + .setNumNulls(1).setCount(1).setMaxValue(Double.POSITIVE_INFINITY).setMinValue(Double.NEGATIVE_INFINITY) + .setIsUnknown(true).setUpdatedTime("") + .build(); + + public static PartitionStatistic ZERO = new PartitionStatisticBuilder().setAvgSizeByte(0).setNdv(new Hll128()) + .setNumNulls(0).setCount(0).setMaxValue(Double.NaN).setMinValue(Double.NaN) + .build(); + + public final double count; + public final Hll128 ndv; + public final double numNulls; + public final double dataSize; + public final double avgSizeByte; + public final double minValue; + public final double maxValue; + public final boolean isUnKnown; + public final LiteralExpr minExpr; + public final LiteralExpr maxExpr; + public final String updatedTime; + + public PartitionStatistic(double count, Hll128 ndv, double avgSizeByte, + double numNulls, double dataSize, double minValue, double maxValue, + LiteralExpr minExpr, LiteralExpr maxExpr, boolean isUnKnown, + String updatedTime) { + this.count = count; + this.ndv = ndv; + this.avgSizeByte = avgSizeByte; + this.numNulls = numNulls; + this.dataSize = dataSize; + this.minValue = minValue; + this.maxValue = maxValue; + this.minExpr = minExpr; + this.maxExpr = maxExpr; + this.isUnKnown = isUnKnown; + this.updatedTime = updatedTime; + } + + public static PartitionStatistic fromResultRow(List<ResultRow> resultRows) { + if (resultRows.size() > 1) { + for (ResultRow resultRow : resultRows) { + LOG.warn("Partition stats has more than one row. [{}]", resultRow); + } + } + PartitionStatistic partitionStatistic = null; + try { + for (ResultRow resultRow : resultRows) { + partitionStatistic = fromResultRow(resultRow); + } + } catch (Throwable t) { + if (LOG.isDebugEnabled()) { + LOG.debug("Failed to deserialize column stats", t); + } + return PartitionStatistic.UNKNOWN; + } + if (partitionStatistic == null) { + return PartitionStatistic.UNKNOWN; + } + return partitionStatistic; + } + + public static PartitionStatistic fromResultRow(ResultRow row) { + // row : [catalog_id, db_id, tbl_id, idx_id, col_id, count, ndv, null_count, min, max, data_size, update_time] + try { + long catalogId = Long.parseLong(row.get(0)); + long dbID = Long.parseLong(row.get(1)); + long tblId = Long.parseLong(row.get(2)); + long idxId = Long.parseLong(row.get(3)); + String colName = row.get(4); + Column col = StatisticsUtil.findColumn(catalogId, dbID, tblId, idxId, colName); + if (col == null) { + LOG.info("Failed to deserialize column statistics, ctlId: {} dbId: {}, " + + "tblId: {} column: {} not exists", catalogId, dbID, tblId, colName); + return PartitionStatistic.UNKNOWN; + } + + PartitionStatisticBuilder partitionStatisticBuilder = new PartitionStatisticBuilder(); + double count = Double.parseDouble(row.get(5)); + partitionStatisticBuilder.setCount(count); + String ndv = row.get(6); + Base64.Decoder decoder = Base64.getDecoder(); + DataInputStream dis = new DataInputStream(new ByteArrayInputStream(decoder.decode(ndv))); + Hll hll = new Hll(); + if (!hll.deserialize(dis)) { + LOG.warn("Failed to deserialize ndv. {}", ndv); Review Comment: refactored ########## fe/fe-core/src/main/java/org/apache/doris/statistics/PartitionStatistic.java: ########## @@ -0,0 +1,165 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.statistics; + +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.catalog.Column; +import org.apache.doris.common.AnalysisException; +import org.apache.doris.common.io.Hll; +import org.apache.doris.statistics.util.Hll128; +import org.apache.doris.statistics.util.StatisticsUtil; + +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.io.ByteArrayInputStream; +import java.io.DataInputStream; +import java.util.Base64; +import java.util.List; + +public class PartitionStatistic { + + private static final Logger LOG = LogManager.getLogger(PartitionStatistic.class); + + public static PartitionStatistic UNKNOWN = new PartitionStatisticBuilder().setAvgSizeByte(1).setNdv(new Hll128()) + .setNumNulls(1).setCount(1).setMaxValue(Double.POSITIVE_INFINITY).setMinValue(Double.NEGATIVE_INFINITY) + .setIsUnknown(true).setUpdatedTime("") + .build(); + + public static PartitionStatistic ZERO = new PartitionStatisticBuilder().setAvgSizeByte(0).setNdv(new Hll128()) + .setNumNulls(0).setCount(0).setMaxValue(Double.NaN).setMinValue(Double.NaN) + .build(); + + public final double count; + public final Hll128 ndv; + public final double numNulls; + public final double dataSize; + public final double avgSizeByte; + public final double minValue; + public final double maxValue; + public final boolean isUnKnown; + public final LiteralExpr minExpr; + public final LiteralExpr maxExpr; + public final String updatedTime; + + public PartitionStatistic(double count, Hll128 ndv, double avgSizeByte, + double numNulls, double dataSize, double minValue, double maxValue, + LiteralExpr minExpr, LiteralExpr maxExpr, boolean isUnKnown, + String updatedTime) { + this.count = count; + this.ndv = ndv; + this.avgSizeByte = avgSizeByte; + this.numNulls = numNulls; + this.dataSize = dataSize; + this.minValue = minValue; + this.maxValue = maxValue; + this.minExpr = minExpr; + this.maxExpr = maxExpr; + this.isUnKnown = isUnKnown; + this.updatedTime = updatedTime; + } + + public static PartitionStatistic fromResultRow(List<ResultRow> resultRows) { + if (resultRows.size() > 1) { + for (ResultRow resultRow : resultRows) { + LOG.warn("Partition stats has more than one row. [{}]", resultRow); + } + } + PartitionStatistic partitionStatistic = null; + try { + for (ResultRow resultRow : resultRows) { + partitionStatistic = fromResultRow(resultRow); + } + } catch (Throwable t) { + if (LOG.isDebugEnabled()) { + LOG.debug("Failed to deserialize column stats", t); + } + return PartitionStatistic.UNKNOWN; + } + if (partitionStatistic == null) { + return PartitionStatistic.UNKNOWN; + } + return partitionStatistic; + } + + public static PartitionStatistic fromResultRow(ResultRow row) { + // row : [catalog_id, db_id, tbl_id, idx_id, col_id, count, ndv, null_count, min, max, data_size, update_time] + try { + long catalogId = Long.parseLong(row.get(0)); + long dbID = Long.parseLong(row.get(1)); + long tblId = Long.parseLong(row.get(2)); + long idxId = Long.parseLong(row.get(3)); + String colName = row.get(4); + Column col = StatisticsUtil.findColumn(catalogId, dbID, tblId, idxId, colName); + if (col == null) { + LOG.info("Failed to deserialize column statistics, ctlId: {} dbId: {}, " + + "tblId: {} column: {} not exists", catalogId, dbID, tblId, colName); + return PartitionStatistic.UNKNOWN; + } + + PartitionStatisticBuilder partitionStatisticBuilder = new PartitionStatisticBuilder(); + double count = Double.parseDouble(row.get(5)); + partitionStatisticBuilder.setCount(count); + String ndv = row.get(6); + Base64.Decoder decoder = Base64.getDecoder(); + DataInputStream dis = new DataInputStream(new ByteArrayInputStream(decoder.decode(ndv))); + Hll hll = new Hll(); + if (!hll.deserialize(dis)) { + LOG.warn("Failed to deserialize ndv. {}", ndv); Review Comment: refactored -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
