airborne12 commented on code in PR #35473:
URL: https://github.com/apache/doris/pull/35473#discussion_r1616738860
##########
be/src/olap/rowset/segment_v2/inverted_index_compaction.cpp:
##########
@@ -40,7 +41,8 @@ Status compact_column(int64_t index_id,
std::vector<lucene::store::Directory*>&
}
})
- lucene::store::Directory* dir = DorisFSDirectoryFactory::getDirectory(fs,
tmp_path.c_str());
+ lucene::store::Directory* dir =
+
DorisFSDirectoryFactory::getDirectory(io::global_local_filesystem(),
tmp_path.data());
Review Comment:
why global_local_filesystem here? index compaction may use remote fs
##########
be/src/olap/rowset/segment_v2/inverted_index_compaction.cpp:
##########
@@ -70,7 +72,7 @@ Status compact_column(int64_t index_id,
std::vector<lucene::store::Directory*>&
}
// delete temporary segment_path
- static_cast<void>(fs->delete_directory(tmp_path.c_str()));
+ std::ignore =
io::global_local_filesystem()->delete_directory(tmp_path.data());
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
