platoneko commented on code in PR #35473:
URL: https://github.com/apache/doris/pull/35473#discussion_r1616634895
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -518,8 +518,7 @@ Status CloudMetaMgr::sync_tablet_rowsets(CloudTablet*
tablet, bool warmup_delta_
rs_meta->init_from_pb(meta_pb);
RowsetSharedPtr rowset;
// schema is nullptr implies using RowsetMeta.tablet_schema
- Status s = RowsetFactory::create_rowset(nullptr,
tablet->tablet_path(), rs_meta,
- &rowset);
+ Status s = RowsetFactory::create_rowset(nullptr, "", rs_meta,
&rowset);
Review Comment:
`tablet_path` 是 local rowset 需要的信息，因为 rowset 没有 Doris 当前本地 rowset 路径中的
`shard_id`、`schema hash`等信息，需要构造函数传入用于将来拼接出来 local segment path；对 remote rowset
可有可无，因为 remote rowset 都是借助 `StorageResouce` 来得到路径。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
