github-actions[bot] commented on code in PR #34679:
URL: https://github.com/apache/doris/pull/34679#discussion_r1597470210
##########
be/src/io/fs/local_file_writer.cpp:
##########
@@ -159,7 +159,8 @@ Status LocalFileWriter::appendv(const Slice* data, size_t
data_cnt) {
return Status::OK();
}
-Status LocalFileWriter::finalize() {
+// TODO(ByteYue): Refactor this function as FileWriter::flush()
+Status LocalFileWriter::_finalize() {
Review Comment:
warning: method '_finalize' can be made const
[readability-make-member-function-const]
```suggestion
Status LocalFileWriter::_finalize() const {
```
be/src/io/fs/local_file_writer.h:43:
```diff
- Status _finalize();
+ Status _finalize() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
