gavinchou commented on code in PR #34679:
URL: https://github.com/apache/doris/pull/34679#discussion_r1597007366
##########
be/src/io/fs/file_writer.h:
##########
@@ -54,25 +55,26 @@ class FileWriter {
FileWriter(const FileWriter&) = delete;
const FileWriter& operator=(const FileWriter&) = delete;
- // Normal close. Wait for all data to persist before returning.
- // If there is no data appended, an empty file will be persisted.
- virtual Status close() = 0;
+ Status close(bool non_block = false);
Review Comment:
we may need UT for the async/nonblocking test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
