yiguolei commented on code in PR #34527:
URL: https://github.com/apache/doris/pull/34527#discussion_r1595165693


##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -113,25 +111,18 @@ void TaskScheduler::_do_work(size_t index) {
         auto* fragment_ctx = task->fragment_context();
         bool canceled = fragment_ctx->is_canceled();
 
-        auto state = task->get_state();
         // If the state is PENDING_FINISH, then the task is come from blocked 
queue, its is_pending_finish
         // has to return false. The task is finished and need to close now.
-        if (state == PipelineTaskState::PENDING_FINISH || canceled) {

Review Comment:
   这个逻辑不一定对。
   当finishdpendency 中唤醒的时候,需要在这里判断一下,是否直接close了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to