yiguolei commented on code in PR #34527:
URL: https://github.com/apache/doris/pull/34527#discussion_r1595163959
##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -86,12 +86,10 @@ void _close_task(PipelineTask* task, PipelineTaskState
state, Status exec_status
// We have already refactor all source and sink api, the close API does
not need waiting
// for pending finish now. So that could call close directly.
Status status = task->close(exec_status);
- if (!status.ok() && state != PipelineTaskState::CANCELED) {
+ if (!status.ok() && !cancel) {
Review Comment:
do not need this flag, the cancel logic should be 幂等
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
