HappenLee commented on code in PR #34402:
URL: https://github.com/apache/doris/pull/34402#discussion_r1590930756
##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -101,8 +98,7 @@ void _close_task(PipelineTask* task, PipelineTaskState
state, Status exec_status
}
void TaskScheduler::_do_work(size_t index) {
- const auto& marker = _markers[index];
- while (*marker) {
+ while (_markers[index]) {
Review Comment:
一样的，不影响结果正确
##########
be/src/pipeline/task_scheduler.h:
##########
@@ -66,8 +66,8 @@ class TaskScheduler {
private:
std::unique_ptr<ThreadPool> _fix_thread_pool;
std::shared_ptr<TaskQueue> _task_queue;
- std::vector<std::unique_ptr<std::atomic<bool>>> _markers;
- std::atomic<bool> _shutdown;
+ std::vector<bool> _markers;
+ bool _shutdown;
Review Comment:
构造函数初始化了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
