github-actions[bot] commented on code in PR #34402:
URL: https://github.com/apache/doris/pull/34402#discussion_r1590363992


##########
be/src/pipeline/task_scheduler.h:
##########
@@ -66,8 +66,8 @@ class TaskScheduler {
 private:
     std::unique_ptr<ThreadPool> _fix_thread_pool;
     std::shared_ptr<TaskQueue> _task_queue;
-    std::vector<std::unique_ptr<std::atomic<bool>>> _markers;
-    std::atomic<bool> _shutdown;
+    std::vector<bool> _markers;
+    bool _shutdown;

Review Comment:
   warning: use default member initializer for '_shutdown' 
[modernize-use-default-member-init]
   
   be/src/pipeline/task_scheduler.h:51:
   ```diff
   -               _shutdown(false),
   +               ,
   ```
   
   ```suggestion
       bool _shutdown{false};
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to