eldenmoon commented on code in PR #32620:
URL: https://github.com/apache/doris/pull/32620#discussion_r1582003271


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -726,6 +732,20 @@ Status SegmentIterator::_extract_common_expr_columns(const 
vectorized::VExprSPtr
     return Status::OK();
 }
 
+Status SegmentIterator::_extract_common_expr_columns_for_index(const 
vectorized::VExprSPtr& expr) {

Review Comment:
   almost the same with `_extract_common_expr_columns` could use the same 
function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to