eldenmoon commented on code in PR #32620:
URL: https://github.com/apache/doris/pull/32620#discussion_r1580383800


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -815,6 +835,17 @@ bool 
SegmentIterator::_can_filter_by_preds_except_leafnode_of_andnode() {
     return true;
 }
 
+bool SegmentIterator::_check_apply_by_inverted_index(ColumnId col_id) {

Review Comment:
   this function is duplicated with 
`SegmentIterator::_check_apply_by_inverted_index(ColumnPredicate* pred, bool 
pred_in_compound)` may be we should put them into one, or rename this function 
to distinguish them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to