AshinGau commented on code in PR #33935:
URL: https://github.com/apache/doris/pull/33935#discussion_r1574042826
##########
be/src/vec/exec/format/table/iceberg_reader.cpp:
##########
@@ -136,6 +138,32 @@ Status IcebergTableReader::init_reader(
return status;
}
+Status IcebergTableReader::init_reader_for_orc(
Review Comment:
Can we abstract the abstract class for the iceberg reader, using parquet/orc
as the concrete implementation? If there are reuse functions between two
formats, it can be moved to the parent class. The code style like `if-else`
often increases the difficulty of later maintenance and modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
