AshinGau commented on code in PR #33935:
URL: https://github.com/apache/doris/pull/33935#discussion_r1573784592
##########
be/.clion.source.upload.marker:
##########
Review Comment:
What's this
##########
be/src/vec/exec/format/table/iceberg_reader.cpp:
##########
@@ -136,6 +138,32 @@ Status IcebergTableReader::init_reader(
return status;
}
+Status IcebergTableReader::init_reader_for_orc(
Review Comment:
Can we abstract the abstract class for the iceberg reader, using parquet/orc
as the concrete implementation? If there are reuse functions between two
formats, it can be moved to the parent class. The code format like `if-else`
often increases the difficulty of later maintenance and modification.
##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -177,6 +177,12 @@ class OrcReader : public GenericReader {
Status get_parsed_schema(std::vector<std::string>* col_names,
std::vector<TypeDescriptor>* col_types) override;
+ Status get_parsed_col_name_iceberg_ids(std::vector<std::string>* col_names,
Review Comment:
Other components like `tvf` will get the file schema/metadata, How to
provide a public interface to get the schema/metadata.
`get_parsed_col_name_iceberg_ids` may be correct, but it is not elegant enough.
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -1684,6 +1699,9 @@ Status OrcReader::get_next_block(Block* block, size_t*
read_rows, bool* eof) {
for (auto& conjunct : _non_dict_filter_conjuncts) {
filter_conjuncts.emplace_back(conjunct);
}
+ for (auto& [missing_col, conjunct] :
_lazy_read_ctx.predicate_missing_columns) {
+ filter_conjuncts.emplace_back(conjunct);
Review Comment:
How to resolve conjuncts like `missing_column1 = missing_column2`, and
`other column = missing_column`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
