yiguolei commented on code in PR #33519:
URL: https://github.com/apache/doris/pull/33519#discussion_r1563695235


##########
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##########
@@ -682,7 +686,9 @@ Status 
PartitionedHashJoinProbeOperatorX::pull(doris::RuntimeState* state,
 
         auto block = std::move(probe_blocks.back());
         probe_blocks.pop_back();
-        RETURN_IF_ERROR(_inner_probe_operator->push(runtime_state, &block, 
false));
+        if (!block.empty()) {

Review Comment:
   这里如果block 是empty,然后也不忘probe operator 里push ,那么672 行会不会死循环?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to