yiguolei commented on code in PR #33519:
URL: https://github.com/apache/doris/pull/33519#discussion_r1563680144
##########
be/src/common/config.cpp:
##########
@@ -1160,13 +1160,13 @@ DEFINE_mDouble(high_disk_avail_level_diff_usages,
"0.15");
DEFINE_Int32(partition_disk_index_lru_size, "10000");
// limit the storage space that query spill files can use
DEFINE_String(spill_storage_root_path, "${DORIS_HOME}/storage");
-DEFINE_mInt64(spill_storage_limit, "10737418240"); // 10G
-DEFINE_mInt32(spill_gc_interval_ms, "2000"); // 2s
+DEFINE_mInt32(spill_storage_usage_percent, "20"); // 20%
Review Comment:
Do not write config like this.
Maybe there are 2 requirements:
1. Set the usage by percent like you do.
2. Set the usage by size, such as 10g, 10T, 100mb
If you add a config like this, then you has to add another config
spill_storage_usage_bytes when meet req 2.
If user set both of them, we do not know which should be used.
You could refer the config mem_limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
