eldenmoon commented on code in PR #33298:
URL: https://github.com/apache/doris/pull/33298#discussion_r1554849235
##########
be/src/cloud/pb_convert.cpp:
##########
@@ -134,19 +137,55 @@ void doris_rowset_meta_to_cloud(RowsetMetaCloudPB* out,
RowsetMetaPB&& in) {
out->set_has_variant_type_in_schema(in.has_variant_type_in_schema());
}
-RowsetMetaPB cloud_rowset_meta_to_doris(const RowsetMetaCloudPB& in) {
+RowsetMetaPB cloud_rowset_meta_to_doris(const RowsetMetaCloudPB& in,
+ std::optional<SchemaCloudDictionary>
dict) {
RowsetMetaPB out;
- cloud_rowset_meta_to_doris(&out, in);
+ cloud_rowset_meta_to_doris(&out, in, dict);
return out;
}
-RowsetMetaPB cloud_rowset_meta_to_doris(RowsetMetaCloudPB&& in) {
+RowsetMetaPB cloud_rowset_meta_to_doris(RowsetMetaCloudPB&& in,
+ std::optional<SchemaCloudDictionary>
dict) {
RowsetMetaPB out;
- cloud_rowset_meta_to_doris(&out, std::move(in));
+ cloud_rowset_meta_to_doris(&out, std::move(in), dict);
return out;
}
-void cloud_rowset_meta_to_doris(RowsetMetaPB* out, const RowsetMetaCloudPB&
in) {
+static void fill_schema_with_dict(const RowsetMetaCloudPB& in, RowsetMetaPB*
out,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
