eldenmoon commented on code in PR #33298:
URL: https://github.com/apache/doris/pull/33298#discussion_r1554849211


##########
cloud/src/meta-service/keys.cpp:
##########
@@ -312,6 +305,12 @@ void meta_pending_delete_bitmap_key(const 
MetaPendingDeleteBitmapInfo& in, std::
     encode_int64(std::get<1>(in), out);                      // table_id
 }
 
+void meta_schema_pb_dictionary_key(const MetaSchemaPBDictionaryInfo& in, 
std::string* out) {

Review Comment:
   done



##########
cloud/src/recycler/recycler.cpp:
##########
@@ -1151,13 +1151,19 @@ int InstanceRecycler::recycle_tablets(int64_t table_id, 
int64_t index_id, int64_
     txn->remove(job_key_begin, job_key_end);
     LOG(WARNING) << "remove job kv, begin=" << hex(job_key_begin) << " end=" 
<< hex(job_key_end);
     std::string schema_key_begin, schema_key_end;
+    std::string schema_dict_key_begin, schema_dict_key_end;
     if (partition_id <= 0) {
         // Delete schema kv of this index
         meta_schema_key({instance_id_, index_id, 0}, &schema_key_begin);
         meta_schema_key({instance_id_, index_id + 1, 0}, &schema_key_end);
         txn->remove(schema_key_begin, schema_key_end);
         LOG(WARNING) << "remove schema kv, begin=" << hex(schema_key_begin)
                      << " end=" << hex(schema_key_end);
+        meta_schema_pb_dictionary_key({instance_id_, index_id}, 
&schema_dict_key_begin);
+        meta_schema_pb_dictionary_key({instance_id_, index_id + 1}, 
&schema_dict_key_end);
+        txn->remove(schema_dict_key_begin, schema_dict_key_end);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to