mymeiyi commented on code in PR #32523:
URL: https://github.com/apache/doris/pull/32523#discussion_r1547059296
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/GroupCommitInsertExecutor.java:
##########
@@ -141,4 +166,44 @@ private void handleGroupCommit(ConnectContext ctx,
DataSink sink,
// update it, so that user can get loaded rows in fe.audit.log
ctx.updateReturnRows((int) response.getLoadedRows());
}
+
+ @Override
+ public void beginTransaction() {
+
+ }
+
+ @Override
+ protected void finalizeSink(PlanFragment fragment, DataSink sink,
PhysicalSink physicalSink) {
+
+ }
+
+ @Override
+ protected void beforeExec() {
+
+ }
+
+ @Override
+ protected void onComplete() throws UserException {
+ Optional<PhysicalOlapTableSink<?>> plan = (planner.getPhysicalPlan()
+
.<Set<PhysicalOlapTableSink<?>>>collect(PhysicalSink.class::isInstance)).stream()
+ .findAny();
+ PhysicalOlapTableSink<?> olapSink = plan.get();
+ DataSink sink = planner.getFragments().get(0).getSink();
+ try {
+ handleGroupCommit(ctx, sink, olapSink, planner);
Review Comment:
why call `handleGroupCommit` in `onComplete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
