mymeiyi commented on code in PR #32523: URL: https://github.com/apache/doris/pull/32523#discussion_r1547056755
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java: ########## @@ -174,13 +174,19 @@ private boolean checkStrictMode() { return true; } + private boolean checkGroupCommitMode() { + return ctx.isGroupCommit(); + } + /** * execute insert txn for insert into select command. */ public void executeSingleInsert(StmtExecutor executor, long jobId) throws Exception { beforeExec(); try { - execImpl(executor, jobId); + if (!checkGroupCommitMode()) { Review Comment: `if (!ctx.isGroupCommit())` to simlify the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org