yiguolei commented on code in PR #33075:
URL: https://github.com/apache/doris/pull/33075#discussion_r1545618535
##########
be/src/pipeline/exec/partitioned_aggregation_sink_operator.cpp:
##########
@@ -168,13 +168,21 @@ Status
PartitionedAggSinkOperatorX::sink(doris::RuntimeState* state, vectorized:
auto* runtime_state = local_state._runtime_state.get();
RETURN_IF_ERROR(_agg_sink_operator->sink(runtime_state, in_block, false));
if (eos) {
- LOG(INFO) << "agg node " << id() << " sink eos";
- if (revocable_mem_size(state) > 0) {
- RETURN_IF_ERROR(revoke_memory(state));
- } else {
- for (auto& partition :
local_state._shared_state->spill_partitions) {
- RETURN_IF_ERROR(partition->finish_current_spilling(eos));
+ local_state.profile()->add_info_string(
Review Comment:
Not meet EOS.
Shoud add this to profile when the spilled is set to true at first time.
Because we will provide realtime profile in the future, user will find his
query is spilled to disk.
If we set it when eos, then user will not find ths spill task when the query
not spilled finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
