yiguolei commented on code in PR #33075:
URL: https://github.com/apache/doris/pull/33075#discussion_r1545618018


##########
be/src/pipeline/exec/partitioned_aggregation_source_operator.cpp:
##########
@@ -133,13 +133,16 @@ Status 
PartitionedAggSourceOperatorX::get_block(RuntimeState* state, vectorized:
     SCOPED_TIMER(local_state.exec_time_counter());
     RETURN_IF_ERROR(local_state._status);
 
-    
RETURN_IF_ERROR(local_state.initiate_merge_spill_partition_agg_data(state));
+    if (local_state._shared_state->is_spilled) {
+        
RETURN_IF_ERROR(local_state.initiate_merge_spill_partition_agg_data(state));

Review Comment:
   why call init merge every time?? It is only called the first time or meet 
previous partition's EOS?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to