github-actions[bot] commented on code in PR #32326:
URL: https://github.com/apache/doris/pull/32326#discussion_r1535023504
##########
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:
##########
@@ -88,5 +88,88 @@ Status
DataTypeIPv6SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&
return Status::OK();
}
+void DataTypeIPv6SerDe::write_column_to_arrow(const IColumn& column, const
NullMap* null_map,
Review Comment:
warning: method 'write_column_to_arrow' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void DataTypeIPv6SerDe::write_column_to_arrow(const IColumn& column,
const NullMap* null_map,
```
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:92:
```diff
- int end, const
cctz::time_zone& ctz) const {
+ int end, const
cctz::time_zone& ctz) {
```
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##########
@@ -88,5 +88,88 @@ Status
DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&
return Status::OK();
}
+void DataTypeIPv4SerDe::write_column_to_arrow(const IColumn& column, const
NullMap* null_map,
Review Comment:
warning: method 'write_column_to_arrow' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void DataTypeIPv4SerDe::write_column_to_arrow(const IColumn& column,
const NullMap* null_map,
```
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:92:
```diff
- int end, const
cctz::time_zone& ctz) const {
+ int end, const
cctz::time_zone& ctz) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
