amorynan commented on code in PR #32326:
URL: https://github.com/apache/doris/pull/32326#discussion_r1531576911
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##########
@@ -88,5 +88,88 @@ Status
DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&
return Status::OK();
}
+void DataTypeIPv4SerDe::write_column_to_arrow(const IColumn& column, const
NullMap* null_map,
+ arrow::ArrayBuilder*
array_builder, int start,
+ int end) const {
+ auto& col_data = static_cast<const ColumnIPv4&>(column).get_data();
+ auto& string_builder = assert_cast<arrow::StringBuilder&>(*array_builder);
+ for (size_t i = start; i < end; ++i) {
+ if (null_map && (*null_map)[i]) {
+ checkArrowStatus(string_builder.AppendNull(), column.get_name(),
+ array_builder->type()->name());
+ } else {
+ std::string ipv4_str = IPv4Value::to_string(col_data[i]);
+ checkArrowStatus(string_builder.Append(ipv4_str.c_str(),
ipv4_str.size()),
+ column.get_name(), array_builder->type()->name());
+ }
+ }
+}
+
+void DataTypeIPv4SerDe::read_column_from_arrow(IColumn& column, const
arrow::Array* arrow_array,
+ int start, int end,
+ const cctz::time_zone& ctz)
const {
+ auto& col_data = static_cast<ColumnIPv4&>(column).get_data();
+ auto concrete_array = dynamic_cast<const arrow::StringArray*>(arrow_array);
+ std::shared_ptr<arrow::Buffer> buffer = concrete_array->value_data();
+
+ for (size_t offset_i = start; offset_i < end; ++offset_i) {
+ if (!concrete_array->IsNull(offset_i)) {
+ const char* raw_data = reinterpret_cast<const char*>(
+ buffer->data() + concrete_array->value_offset(offset_i));
+ const auto raw_data_len = concrete_array->value_length(offset_i);
+
+ IPv4 ipv4_val;
+ if (!IPv4Value::from_string(ipv4_val, raw_data, raw_data_len)) {
+ throw doris::Exception(ErrorCode::INVALID_ARGUMENT,
+ "parse number fail, string: '{}'",
+ std::string(raw_data,
raw_data_len).c_str());
+ }
+ col_data.emplace_back(ipv4_val);
+ }
+ }
+}
+
+Status DataTypeIPv4SerDe::write_column_to_orc(const std::string& timezone,
const IColumn& column,
Review Comment:
why do this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
