github-actions[bot] commented on code in PR #31827:
URL: https://github.com/apache/doris/pull/31827#discussion_r1534851392
##########
be/src/exec/tablet_info.cpp:
##########
@@ -551,16 +504,84 @@ Status
VOlapTablePartitionParam::_create_partition_key(const TExprNode& t_expr,
part_key->second = column->size() - 1;
return Status::OK();
}
+// NOLINTEND(readability-function-size)
+
+Status VOlapTablePartitionParam::_create_partition_keys(const
std::vector<TExprNode>& t_exprs,
Review Comment:
warning: method '_create_partition_keys' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status VOlapTablePartitionParam::_create_partition_keys(const
std::vector<TExprNode>& t_exprs,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
