github-actions[bot] commented on code in PR #31827:
URL: https://github.com/apache/doris/pull/31827#discussion_r1531461993
##########
be/src/vec/columns/column_const.h:
##########
@@ -218,6 +247,30 @@ class ColumnConst final : public COWHelper<IColumn,
ColumnConst> {
}
}
+ int compare_concrete_at(size_t n, size_t m, const IColumn& rhs,
+ int nan_direction_hint) const override {
Review Comment:
warning: method 'compare_concrete_at' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static int compare_concrete_at(size_t n, size_t m, const IColumn& rhs,
int nan_direction_hint) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
