zclllyybb commented on code in PR #31827:
URL: https://github.com/apache/doris/pull/31827#discussion_r1528710514


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateTimeV2Literal.java:
##########
@@ -75,6 +76,10 @@ private void roundMicroSecond(int scale) {
             this.second = localDateTime.getSecond();
             this.microSecond -= 1000000;
         }
+        if (checkRange() || checkDate()) {
+            // may fallback to legacy planner. make sure the behaviour of 
rounding is same.

Review Comment:
   add some test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to