zclllyybb commented on code in PR #31827:
URL: https://github.com/apache/doris/pull/31827#discussion_r1528709862
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/PartitionExprUtil.java:
##########
@@ -124,15 +124,23 @@ public static Map<String, AddPartitionClause>
getAddPartitionClauseFromPartition
FunctionIntervalInfo intervalInfo =
getFunctionIntervalInfo(partitionExprs, partitionType);
Set<String> filterPartitionValues = new HashSet<String>();
- for (List<TStringLiteral> partitionValueList : partitionValues) {
+ for (List<TNullableStringLiteral> partitionValueList :
partitionValues) {
PartitionKeyDesc partitionKeyDesc = null;
String partitionName = "p";
ArrayList<String> curPartitionValues = new ArrayList<>();
- for (TStringLiteral tStringLiteral : partitionValueList) {
- curPartitionValues.add(tStringLiteral.value);
+ for (TNullableStringLiteral tStringLiteral : partitionValueList) {
+ if (tStringLiteral.is_null) {
+ if (partitionType == PartitionType.RANGE) {
+ throw new AnalysisException("Can't create partition
for NULL Range");
Review Comment:
add some test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
