yiguolei commented on code in PR #32039:
URL: https://github.com/apache/doris/pull/32039#discussion_r1519087510
##########
be/src/runtime/memory/lru_cache_policy.h:
##########
@@ -19,20 +19,40 @@
#include <fmt/format.h>
+#include <memory>
+
#include "olap/lru_cache.h"
#include "runtime/memory/cache_policy.h"
+#include "runtime/thread_context.h"
+#include "util/doris_metrics.h"
#include "util/time.h"
namespace doris {
+class CacheValueWarpper {
+public:
+ CacheValueWarpper(void* value, void (*deleter)(const CacheKey& key, void*
value),
+ size_t bytes_with_handle,
+ const std::shared_ptr<MemTrackerLimiter>& mem_tracker)
+ : value(value),
+ deleter(deleter),
Review Comment:
add delete as a virtual function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
