yiguolei commented on code in PR #32039:
URL: https://github.com/apache/doris/pull/32039#discussion_r1519047398


##########
be/src/olap/schema_cache.h:
##########
@@ -86,7 +86,7 @@ class SchemaCache : public LRUCachePolicy {
         if (!instance() || key.empty()) {
             return;
         }
-        CacheValue* value = new CacheValue;

Review Comment:
   不要直接new,否则加入90 行之后某个地方直接return error 啥的,就泄露了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to